Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1542 - GraalVMNativeImagePlugin ignores resources in src/graal #1543

Merged
merged 1 commit into from
Jul 23, 2023

Conversation

heaven-born
Copy link
Contributor

Fixes #1542

@lightbend-cla-validator

Hi @heaven-born,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

@heaven-born
Copy link
Contributor Author

I signed the CLA

Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. I'm not too familiar with graalvm, but sounds legit that you want to include resources.

Did the Universal / mappings setting not workout for you?

@heaven-born
Copy link
Contributor Author

Doesn't look like Universal / mappings has any effect on GraalVMNativeImagePlugin, but I tried just in case, and it didn't work out.
But even if it did, it wouldn't be the way as it is documented in https://www.scala-sbt.org/sbt-native-packager/formats/graalvm-native-image.html :

If you are building the image in a docker container, and you have any resources that need to be available to the native-image command, such as files passed to -H:ResourceConfigurationFiles or -H:ReflectionConfigurationFiles, you can place these in your projects src/graal directory. Any files in there will be made available to the native-image docker container under the path /opt/graalvm/stage/resources.

Currently, all resources placed in src/graal directory are not accessible for -H:ResourceConfigurationFiles and -H:ReflectionConfigurationFiles, because /opt/graalvm/stage/resources is not in classpath.

@heaven-born
Copy link
Contributor Author

I signed the CLA, should I restart the build somehow to make this check pass now?

@muuki88 muuki88 merged commit 9edd55a into sbt:master Jul 23, 2023
@muuki88
Copy link
Contributor

muuki88 commented Jul 23, 2023

I'll release ASAP

@muuki88
Copy link
Contributor

muuki88 commented Jul 24, 2023

Version 1.9.17 is on it's way

@heaven-born
Copy link
Contributor Author

looks like something went wrong with the build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraalVMNativeImagePlugin ignores resources in src/graal
3 participants