Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1345 - do not buffer logging for native-image output #1540

Merged
merged 1 commit into from
Apr 8, 2023

Conversation

nikolaylagutko
Copy link
Contributor

Replace default BufferedLogger implementation of ProcessLogger with custom implementation that does not bufferize output - so the stdout of Process come to log immediately, but not at the Process exit

@lightbend-cla-validator
Copy link

Hi @nikolaylagutko,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

@muuki88 muuki88 added the graalvm GraalVM releated issues label Apr 8, 2023
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. What issues where you having? Is the log completely empty during the build?

@muuki88 muuki88 merged commit 7ae83ab into sbt:master Apr 8, 2023
@nikolaylagutko
Copy link
Contributor Author

@muuki88 the log is here, but it had printed output only when native-image command finished. As my build takes few minutes - it's much pretty to see the some log lines with process to be sure it working :-D
More detailed can be found here #1345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graalvm GraalVM releated issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants