Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong symlink location #153

Merged
merged 2 commits into from
Feb 4, 2014
Merged

Wrong symlink location #153

merged 2 commits into from
Feb 4, 2014

Conversation

muuki88
Copy link
Contributor

@muuki88 muuki88 commented Feb 4, 2014

  • The lintian error was not removed it was only replaced with a bug
  • Lintian error now shows up again
  • Added regression test
  • Symlink creation really needs a refactoring

@@ -12,3 +12,4 @@ $ exists target/debian-test-0.1.0/DEBIAN/postinst

# Check files for defaults
> check-control-files
> check-softlink target/debian-test-0.1.0/usr/bin/debian-test points to /usr/share/debian-test/bin/debian-test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amusing. THe "points to" is redudantant, but a bit "iffy" in general :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, also if/when this is fixed to be a relative link, I can't get a feeling for whether the test will break....

@jsuereth
Copy link
Member

jsuereth commented Feb 4, 2014

Thanks for the workaround! Much appreciated for now.

jsuereth added a commit that referenced this pull request Feb 4, 2014
@jsuereth jsuereth merged commit 1970748 into master Feb 4, 2014
@jsuereth jsuereth deleted the wip/wrong-symlink-location branch February 4, 2014 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants