Use defaultLinuxLogsLocation for /var/log #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log directory 'logs' in the installation directory is soft-linked to /var/log/app-name/. Instead of hard coding /var/log use the already provided variable defaultLinuxLogsLocation.
|
IMHO for tests java7 is okay. Only for the plugin itself we keep the java 6 compatibility. |
|
Actually, tests still cause an issue. The only way to ensure Java6 compatibility is to build directly (and test) on Java6 (yay for rt.jar that isn't really compatible). However, you can use any linux utiltiy in your test to validate symlinks and we can ensure this is available on our test machine(s). Thanks for the fix! Looks great to me. |
|
So, replacing the java7 code with something like import scala.sys.process._
val link = Paths.get(args(0))
val absolutePath = ("readlink -f " + link).!!
assert(...) |
|
@muuki88 exactly. |
Add a new test 'debian/log-directory' to check that a custom setting for defaultLinuxLogsLocation is correctly applied.
|
Ok, I’ve added a test based on |
muuki88
added a commit
that referenced
this pull request
Feb 3, 2014
Use defaultLinuxLogsLocation for /var/log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log directory
logsin the installation directory is soft-linked to/var/log/app-name/. Instead of hard coding/var/loguse the already provided variabledefaultLinuxLogsLocation.I would also offer to add a test and have prepared one in 3f81f5b, but I only know how to check symbolic links using Java 7’s NIO2 and I think you try to keep Java 6 compatibility.