appUser and appGroup now correctly own the installation directory #143
Conversation
| @@ -63,6 +63,13 @@ object JavaAppPackaging { | |||
| for { | |||
| s <- script.toSeq | |||
| } yield s -> ("bin/" + name + ".bat") | |||
| }, | |||
| linuxPackageMappings in Debian <+= (normalizedName, defaultLinuxInstallLocation, target in Debian, appUser in Linux, appGroup in Linux) map { | |||
There was a problem hiding this comment.
only in Debian because RPM handles things differently, right?
There was a problem hiding this comment.
Actually, I think this should also be in the RPM side....
There was a problem hiding this comment.
It should be on the RPM side and I started going down that route but ended up taking the simple option as this is really needed for my previous PR
|
LGTM at first sight. I hopefully can give it a try this weekend. After we merged this, I try to clean up the |
|
Yeah, LGTM minus the one oddity of owning the linu package. |
…talldir appUser and appGroup now correctly own the installation directory
|
DOH - Meant to wait for ocnfirmation on the owning directory first. Will try to cleanup soon. |
|
@muuki88 what changes are you thinking for I know user and group creation needs tightening up due to edge cases around |
|
A few things
|
appGrouphas been added