Move some defaults of docker to global scope #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lunaryorn, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
SBT strongly recommends to use the global scope for default settings, see https://www.scala-sbt.org/1.x/docs/Plugins-Best-Practices.html#Provide+default+values+in This allows to set the docker image and common labels once in ThisBuild for all subprojects, and makes it easier to use a different docker-compatible container builder by overriding the command, e.g. sbt 'set ThisBuild / dockerExecCommand := Seq("podman")' docker:publish
|
I should like to point out that while I am fairly confident that this works I didn't test it, because I'm admittedly too lazy to bother with publishing locally and adding it to a project 😬 |
|
|
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SBT strongly recommends to use the global scope for default settings,
see https://www.scala-sbt.org/1.x/docs/Plugins-Best-Practices.html#Provide+default+values+in
This allows to set the docker image and common labels once in ThisBuild
for all subprojects, and makes it easier to use a different
docker-compatible container builder by overriding the command, e.g.