-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Graalvm docker repository & build version #1395
Conversation
Hi @kgston, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll see if the test fails on my machine. CI seems good.
I assume this due to graalvm
|
I can update that to the latest version and see if that changes anything. But I think that only affects the "local" Graalvm compile test and not the docker compile test |
Seems like the Java repo the Github action is trying to pull from only has up to 20.3.0 at this time. 🤔 |
Noice. The GitHub UI is really a breeze to use. |
Graalvm 21.0.0 has been released on Jabba, any chance we can merge this fix in? The CI checks seem to pass, so I assume that the test that is failing locally for me has to do with some local config I might be missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 👍😎
Closes #1394.
For some reason, the native-image binary is not able to find the Main class... when running
sbt scripted graalvm-native-image/*
Didn't look too deep into the cause yet.