Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1382: Detect config files regardless of execute permission #1383

Merged
merged 2 commits into from
Dec 17, 2020
Merged

Issue 1382: Detect config files regardless of execute permission #1383

merged 2 commits into from
Dec 17, 2020

Conversation

SalehDehqanpour
Copy link
Contributor

@SalehDehqanpour SalehDehqanpour commented Dec 13, 2020 •
edited
Loading

Fixes #1383
Fixing the order of processing linux mapping files so the conf files are always treated as conf regarless of permission

@lightbend-cla-validator
Copy link

Hi @salehdeh76,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

@muuki88 muuki88 mentioned this pull request Dec 14, 2020
Closed
@muuki88
Copy link
Contributor

muuki88 commented Dec 14, 2020

Sorry that the build fails. There seems to be an issue regarding github actions.

@muuki88
Copy link
Contributor

muuki88 commented Dec 14, 2020

Adressed in #1384

@lightbend-cla-validator
Copy link

Hi @salehdeh76,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

@muuki88
Copy link
Contributor

muuki88 commented Dec 15, 2020

Branch updated

@muuki88
Copy link
Contributor

muuki88 commented Dec 16, 2020

@salehdeh76 thanks for pull request ❤️ Can you sign the CLA then this is good to go 😃

@SalehDehqanpour
Copy link
Contributor Author

SalehDehqanpour commented Dec 16, 2020 •
edited
Loading

@salehdeh76 thanks for pull request ❤️ Can you sign the CLA then this is good to go 😃

@muuki88 Thank you. Yes I've signed it. But just don't know how to trigger the bot to check it again! 😃

@muuki88 muuki88 merged commit dbc85c4 into sbt:master Dec 17, 2020
@muuki88 muuki88 added debian minor release drafter version labels Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muuki88 muuki88 Awaiting requested review from muuki88

Assignees
No one assigned
Labels
debian minor release drafter version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SalehDehqanpour @lightbend-cla-validator @muuki88