Omit removed Java modules from detected jlinkModules #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigredo-tori
force-pushed
the
removed-java-modules
branch
from
853ab43
to
0171ca3
Compare
|
I've also added |
muuki88
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're already skipping detection for some Jakarta modules that have legacy
java.*names. However, there is another source of information - the release notes for Java 11 have a list of all removed modules. This PR filters these out as well. Although there is some overlap, I've opted to keep the lists from two sources separate, since the modules are filtered out for different reasons.Regarding compatibility, this shouldn't impact most builds that use Java 11 and later. For such a build the removed modules could only have come from Jakarta artifacts and such, so they should be present in the project's classpath anyway.