Fix windows / test-bat-template #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The final native-image executable cannot be located in the file native-image.cmd unless the full path to native-image.cmd is given. Therefore, a new parameter is provided to the user to specify the native-image.cmd location. * Picks the right CLASSPATH separator according to the OS instead of hardcoded to colon. Using Colon will fail in Windows build. * Tested against GraalVM 20.0.0 and VS 2019.
…aalVMNativeImagePlugin.scala Co-Authored-By: nigredo-tori <nigredo.tori@gmail.com>
* Use `Seq` for better manage command lines management. * Cannot fix "include symbols with double q" because there is no way to escape '<' and '>' symbols during `cmd` execution. Is there a way to do so? * Have to trim the argument for `include symbols on normal args` otherwise it won't pass the test.
muuki88
previously approved these changes
Mar 10, 2020
muuki88
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seqfor better manage command lines management.cmdexecution. Is there a way to do so?include symbols on normal argsotherwise it won't pass the test.