Bring the SystemV init.d scripts inline with the Debian policies #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1 +1,2 @@ | |||
| update-rc.d ${{app_name}} defaults | |||
There was a problem hiding this comment.
This line adds the script to autostart, right?
|
It looks good to me. I'll try to test it this week. While taking a look I found something. service ${{app_name}} stop || echo "${{app_name}} wasn't even running!"will this succeed? |
|
Yes: On Ubuntu systems you can control init.d scripts using the I have a few more tweaks to add but I haven't finished testing them. |
|
At worst the message will show up needless, but that should be harmless, right? In the future, maybe we should have a different stop template for SystemV perhaps. |
|
Cool! THis looks great, thanks much for the fixes. |
jsuereth
added a commit
that referenced
this pull request
Jan 13, 2014
Bring the SystemV init.d scripts inline with the Debian policies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in the process of updating the init.d script and require a new template, being a Scala noob could someone review it?