Improve error handling in ZIP utilities #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retronym
commented
Dec 11, 2019
| case t: Throwable => | ||
| IOUtils.closeQuietly(zipOut) | ||
| throw t | ||
| } finally { |
There was a problem hiding this comment.
Oh for Java's try-with-resources.
retronym
force-pushed
the
topic/zip-error-handling
branch
from
f86b482
to
ea173c4
Compare
muuki88
approved these changes
Dec 11, 2019
|
Started |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the root cause of #1035. It no longer is as big a problem since #1026 pre-validates that files exists, but it seems worth cleaning this up.