Autoremove multi-stage intermediate image(s) #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muuki88
reviewed
Nov 15, 2019
There was a problem hiding this comment.
Thanks a lot for your work on this @mkurz ❤️ 😎
As the docker file output changed there's one failing integration test:
https://travis-ci.org/sbt/sbt-native-packager/jobs/612122899#L1050-L1082
I have some questions about the implementations as I'm not sure I fully understand what's going on or which issues are being solved 😄
src/main/scala/com/typesafe/sbt/packager/docker/DockerPlugin.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/typesafe/sbt/packager/docker/DockerPlugin.scala
Outdated
Show resolved
Hide resolved
|
@muuki88 I pushed commits to fix the failing test and to search for the |
|
|
|
Thanks a lot @muuki88! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1229
Splitted in
threefour clean commits.Let me know what you think. Thanks!
EDIT: Solution was inspired from here: moby/moby#34513 (comment)