Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention "username" and "password" for docker registry login #1275

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Mention "username" and "password" for docker registry login #1275

merged 2 commits into from
Nov 5, 2019
+4 −3

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Nov 2, 2019

See #654 (comment)

Also added a reference to the GitHub issue for the interested reader.

@mkurz mkurz mentioned this pull request Nov 2, 2019
Closed
muuki88
muuki88 approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the native packager documentation ❤️

@mkurz
Copy link
Member Author

mkurz commented Nov 5, 2019

Thanks @muuki88 - you can hit the merge button now 😉

@muuki88 muuki88 merged commit 62dae72 into sbt:master Nov 5, 2019
@mkurz mkurz deleted the mention-docker-password branch November 5, 2019 19:03
@muuki88
Copy link
Contributor

muuki88 commented Nov 8, 2019

merge it like they merge it on discovery channel 🎤 🎶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muuki88 muuki88 muuki88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkurz @muuki88