JlinkPlugin: support multi-release dependencies #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muuki88
approved these changes
Jul 10, 2019
| autoScalaLibrary in ThisBuild := false | ||
|
|
||
| // Should succeed for multi-release artifacts | ||
| val issue1243 = project |
There was a problem hiding this comment.
I quite like this naming convention for the projects!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1243 .
releasefile and get the value ofJAVA_VERSIONproperty. The "useful" part of the version number (e.g. 11 for 11.0.3, or 9 for 1.9.0), is then passed to jdeps (--multi-release).scriptedtest project for this. There's a bit of over-engineering here, so that in the future we don't have to add a whole test project for simple chages like this.