Fix dependency handling in JlinkPlugin (+ general improvements) #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muuki88
approved these changes
May 24, 2019
| val jlinkModules = TaskKey[Seq[String]]("jlinkModules", "Modules to link") | ||
|
|
||
| val jlinkIgnoreMissingDependency = | ||
| TaskKey[((String, String)) => Boolean]( |
There was a problem hiding this comment.
Can you add some docs what the the function types represent in `(String, String) => Boolean)
| final case class Module(name: String) extends Source | ||
| final case class JarOrDir(name: String) extends Source | ||
|
|
||
| private val pattern = """^\s+([^\s]+)\s+->\s+([^\s]+)\s+([^\s].*?)\s*$""".r |
There was a problem hiding this comment.
Can you add examples for some common patterns that occur?
muuki88
approved these changes
May 28, 2019
|
Thanks @nigredo-tori for your work ❤️ |
|
|
|
@nigredo-tori given your recent activity and incredible contributions, are you interested in commit rights and being more active for native-packager. If you are interested, but are unsure what this implies, we can either chat/email/hangout and I can answer any questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined here:
jdeps --print-module-depsis unreliable - switch to parsing the fulljdepsoutput.jdepsbehavior (throwing an error for missing dependencies) seems to be useful - include similar functionality into the new implementation.jlinkIgnoreMissingDependency). Add convenience helpers (JlinkPlugin.Ignore).General improvements:
jlinkModules) to allow manually adding/removing these.Compile / fullClasspathto allow injecting classpath elements for the scan. This can be useful if not all the relevant dependencies should be a part of the actual classpath (I have a use case for that).