Cleaning up Lintian errors and warnings #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and SystemV files
…etween /usr/bin/.. and /usr/share/<app>/bin/.. files
| @@ -88,7 +88,7 @@ trait GenericPackageSettings | |||
| if !file.isDirectory | |||
| if name startsWith "bin/" | |||
| if !(name endsWith ".bat") // IGNORE windows-y things. | |||
| } yield LinuxSymlink("/usr/" + name, installLocation+"/"+pkg+"/"+name) | |||
| } yield LinuxSymlink("/usr/" + name, installLocation.stripPrefix("/usr/")+"/"+pkg+"/"+name) | |||
|
Thanks for the fixes! |
jsuereth
added a commit
that referenced
this pull request
Jan 6, 2014
Cleaning up Lintian errors and warnings
|
@jsuereth Happy to help. Sorry for being late to the party on reviewing the docs in your PR |
|
@aparkinson Feel free to review them. It's not to late to fix em. I pushed an M1, I'm hoping to push an M2 in another week with RPM support. I'd love for you to help write more docs. They need some massive improvements to actually be useful :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/etc/.. files related to Upstart and SystemV weren't correctly marked as configuration files and upgrading the package could cause any changes made by the system administrator to be lost. This generates a 'file-in-etc-not-marked-as-conffile' error in Lintian.
Symlinks to files which are in the same top-level directory should be relative according to debian policy; handy when installing packages into a jail or using non-standard system layout. Symlinks created in /usr/bin weren't creating a relative symlink to /usr/share//bin
This fixes the common Lintian errors but there are one or two warnings remaining