Process -XX arguments as JVM args

[longshorej]

-XX... arguments now added to the JVM. Without this, the following fails:

javaOptions in Universal ++= Seq(
"-XX:+UnlockExperimentalVMOptions",
"-XX:+UseCGroupMemoryLimitForHeap"
)

Bad root server path: /opt/docker/-XX:+UnlockExperimentalVMOptions

[muuki88]

Thanks a lot for your pull request 😍

To make your example work you would have to prepend -J to the -XX parameters.

javaOptions in Universal ++= Seq(
  "-J-XX:+UnlockExperimentalVMOptions",
  "-J-XX:+UseCGroupMemoryLimitForHeap"
)

However my understanding is that this -J separation was introduced to allow
a separation between JVM and application arguments. The -XX arguments should
always be jvm args, so IMHO this pull request makes it a bit less confusing for new comers :)

Hint from the documentation: http://sbt-native-packager.readthedocs.io/en/latest/archetypes/java_app/customize.html#via-application-ini

[longshorej]

Ah, thanks for that tip @muuki88, that works nicely.

[guizmaii]

Hi,

I don't understand.
What's the difference between using the previously accepted format:

javaOptions in Universal ++= Seq(
  "-J-XX:+UnlockExperimentalVMOptions",
  "-J-XX:+UseCGroupMemoryLimitForHeap"
)

and the new one:

javaOptions in Universal ++= Seq(
  "-XX:+UnlockExperimentalVMOptions",
  "-XX:+UseCGroupMemoryLimitForHeap"
)

Where and why should I prefer the new one ?