Convert dockerVersion from a setting to a task #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muuki88
approved these changes
Oct 27, 2017
There was a problem hiding this comment.
Thanks for further improving this 😎🤩
IMHO the difference between settings and tasks is not how the value is produced, but what kind of value.
I found setting was a the right choice as the version is static and doesn't change. However the unwanted logging is indeed annoying and probably not easy to fix. So we should use this.
|
@dwickern interested in getting commit rights? 😍 |
|
@muuki88 Sure, you can add me |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I get errors when starting sbt when the machine can't connect to docker
Since fetching the docker version involves starting a process and/or making an HTTP request, it seems like it should be a task rather than a setting.