strip snapshot suffix safely (#1004)

[colin-lamed]

Related issue: #1004

[lightbend-cla-validator]

Hi @colin-passiv,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

[muuki88]

@colin-passiv thanks a lot for your pull request :)

What was the problem you encountered with the current implementation? I like your change as it removes code and uses native method instead of doing string manipulation on our own. +1 for the tests, but I'm not quite sure what regression they show.

[colin-lamed]

The code was checking the project.version for snapshot suffix, but trimming the snapshot suffix off rpm.version. In the case where project.version had a snapshot suffix, but rpm.version was explicitly set to something without, the rpm.version was being blanked, and the build would fail.

[vpavkin]

+1, have the same issue. #971 was a breaking change for those who used custom rpm version for snapshot builds.

Also for some reason I can't rollback to 1.2.0-M9, because sbt always resolves 1.2.0 for any milestone version (1.2.0-M*).

[vpavkin]

managed to workaround with this setting:

rpmMetadata := rpmMetadata.value.copy(
    version = (version in Rpm).value.stripSuffix("-SNAPSHOT")
)

[dpennell]

This version in 1.2.0 also breaks when isSnapshot is true and the version does not contain '-SNAPSHOT', as is the case when you use the sbt-dynver plugin. This plugin appears to be gaining some traction, so it might be reasonable to release a version with this PR.

@vpavkin Thanks for the workaround - I didn't realize that rpmMetadata was exposed as a setting.

[muuki88]

Hi @dpennell :) great to see you back here.

I'll try to release ASAP.

[muuki88]

1.2.1 released

[dpennell]

@muuki88 Thanks! Nice to be back.