Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for rocket / rkt #557

Closed
benmccann opened this issue Apr 19, 2015 · 11 comments
Closed

Support for rocket / rkt #557

benmccann opened this issue Apr 19, 2015 · 11 comments

Comments

@benmccann
Copy link
Contributor

It could be cool to add support to sbt for building rkt containers. I think we could basically just copy what @justinsb did in justinsb/docker-maven-plugin@aaa5db4

@muuki88
Copy link
Contributor

muuki88 commented Apr 19, 2015

Sounds great. You have time for a pr?

@justinsb
Copy link

I will have a look to see if I can add support :-)

@muuki88
Copy link
Contributor

muuki88 commented Apr 21, 2015

Awesome, thanks :) If you need any help don't hesitate to ask.

@justinsb
Copy link

I've had a look; I'm trying to reuse the appc-java package here (the idea being that we create one library for the JVM). However, it looks like scala has a problem loading this library, because I hit this error:

[error] error while loading ContainerBuilder, class file '/Users/justinsb/rocket/sbt-native-packager/lib/appc-0.1.0-SNAPSHOT.jar(com/coreos/appc/ContainerBuilder.class)' is broken
[error] (class java.lang.NullPointerException/null)

It looks like this is because some of the annotations aren't found (?) - at least that is what Stack Overflow suggested. I'm guessing this is because appc-java uses the AWS SDK now, which uses gson.

I'm happy to make whatever changes to appc-java that are helpful, but I'm not a Scala expert so it looks like I'm stuck here!

@muuki88
Copy link
Contributor

muuki88 commented Apr 27, 2015

Do you have a link to the current state of you work (like commit sha of your fork)? Then it would be easier to take a look. And the stackoverflow questions you mentioned would be nice to take a look at. From what I see

  • lib/appc-0.1.0-SNAPSHOT.jar is this not on maven-central?
  • gson works with scala case classes (as far as I have used it)

benmccann pushed a commit to benmccann/sbt-native-packager that referenced this issue Apr 27, 2015
@benmccann
Copy link
Contributor Author

@justinsb I wonder if it could also be the version of Scala that's being used. I see a bug that looks related that was fixed in Scala 2.10.4 and it appears sbt-native-packager is using 2.10.2. I sent a PR to upgrade, so perhaps worth a shot to see if that helps.

benmccann pushed a commit to benmccann/sbt-native-packager that referenced this issue Apr 28, 2015
muuki88 added a commit that referenced this issue Apr 29, 2015
Use Scala 2.10.5 so that we don't hit SI-7439 as reported in #557 by @justinsb
@muuki88
Copy link
Contributor

muuki88 commented Apr 29, 2015

@justinsb I'll release a 1.0.1 this WE then you can give it another try :)

@muuki88
Copy link
Contributor

muuki88 commented Apr 29, 2015

released.

@benmccann
Copy link
Contributor Author

@justinsb could you give your code another shot now that we've updated the Scala version? or share it so that we can try it?

@yaneeves
Copy link

Any update?

@muuki88
Copy link
Contributor

muuki88 commented Jan 17, 2016

cc @justinsb

@muuki88 muuki88 closed this as completed Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants