Skip to content

Commit

Permalink
Fix typo in debian systemv script.
Browse files Browse the repository at this point in the history
An `if` construct was not properly closed by `fi` which led to errors
when trying to start the system service.
Furthermore a space was required within the `if` construct.
  • Loading branch information
jan0sch committed May 26, 2016
1 parent 38d8353 commit a1d6023
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ start_daemon() {
[ -d "/var/run/${{app_name}}" ] || install -d -o "$DAEMON_USER" -g "$DAEMON_GROUP" -m755 "/var/run/${{app_name}}"
logfile="${{daemon_log_file}}"
stdout_redirect=""
if [ ! -z "${logfile:-}"]; then
if [ ! -z "${logfile:-}" ]; then
stdout_redirect=" >> ${{logdir}}/${{app_name}}/$logfile 2>&1"
if
fi

if [ "$create_pidfile" = true ]; then
start-stop-daemon --background --chdir ${{chdir}} --chuid "$DAEMON_USER" --make-pidfile --pidfile "$PIDFILE" --startas "$RUN_CMD" --start -- $RUN_OPTS "$stdout_redirect"
Expand Down

3 comments on commit a1d6023

@mattmonkey83
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This typo is present in release 1.1.3. Will it be backported to the next 1.1.x release?

@muuki88
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can open a pull request against the 1.1.x and I'll release that fix ASAP.

@mattmonkey83
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done - #846

Please sign in to comment.