Skip to content
This repository has been archived by the owner on Apr 25, 2021. It is now read-only.

recommend a JDK, or remove that codepath #115

Closed
fommil opened this issue Aug 25, 2016 · 2 comments
Closed

recommend a JDK, or remove that codepath #115

fommil opened this issue Aug 25, 2016 · 2 comments

Comments

@fommil
Copy link
Contributor

fommil commented Aug 25, 2016

initially proposed in #113 there is a check for java version which is insufficient (it doesn't check that the java version is suitable for the version of scala) and suggests a broken remedy: i.e. download a JRE.

Either link to a JDK or don't bother with the check (which is the Windows behaviour).
@javabrett javabrett mentioned this issue Nov 10, 2017
Closed
@javabrett
Copy link
Contributor

Probably feedback required here - is there value in running sbt with just a JRE and not a JDK - is that valid?

@fommil
Copy link
Contributor Author

fommil commented Nov 10, 2017

@javabrett sbt assumes that javac is available.

javabrett added a commit to javabrett/sbt-launcher-package that referenced this issue Nov 10, 2017
@javabrett
Changed references to downloading/installing/updating Java (JRE?) to …
da02335 
…refer to JDK.

Updated download URLs. Fixed sbt#115.
@javabrett javabrett mentioned this issue Nov 10, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@javabrett @fommil