Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gjavah #43

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Upgrade gjavah #43

merged 2 commits into from
Jul 23, 2021

Conversation

sideeffffect
Copy link
Contributor

No description provided.

@pomadchin
Copy link
Member

Thanks for your first contribution! 🎉
Hmm, I'm wondering, can we make a direct dependecy on https://github.com/Glavo/gjavah?

@pomadchin pomadchin self-assigned this Jul 23, 2021
@sideeffffect
Copy link
Contributor Author

Unfortunately, gjavah isn't published to Maven Central.
So I'd prefer to just "upgrade" it like this PR does.

@pomadchin
Copy link
Member

pomadchin commented Jul 23, 2021

@sideeffffect hmm got it, and https://jitpack.io doesn't work for you?
But anyway I'm good to merge it as-is in order to avoid having a dependency to an extra repo.

@sideeffffect
Copy link
Contributor Author

jitpack.io is neat, but it's more of a hack. Many people rely on mirrors that include only Maven Central (and maybe few other prominent repositories), typically enterprises, etc...

@pomadchin pomadchin force-pushed the update-gjavah branch 3 times, most recently from 7b29801 to 9654bb3 Compare July 23, 2021 14:45
@pomadchin
Copy link
Member

Merging once CI is 🟢

@pomadchin pomadchin merged commit e1d5bb1 into sbt:main Jul 23, 2021
@sideeffffect sideeffffect deleted the update-gjavah branch July 23, 2021 15:12
@pomadchin pomadchin removed their assignment Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants