-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of multiple native outputs #186
Conversation
I tested it on a project https://github.com/datben/jni-test, as the result it puts two binaries into the jar. The behavior looks legit! |
3377447
to
911e358
Compare
@pomadchin how can i add this branch in my sbt plugin, i tried this : addSbtPlugin("com.github.sbt" % "sbt-jni" % "1.6.0+40-911e3587-SNAPSHOT" from "https://github.com/sbt/sbt-jni.git#feature/list-files") but it doesnt work (i am not very familiar with sbt plugins) |
@datben we don't not push to artifactory from branches; the easiest way to test like any scala project: clone, checkout branch, $ git clone git@github.com:sbt/sbt-jni.git; cd sbt-jnil; git checkout feature/list-files
$ sbt publishLocal
# bump plugin version here https://github.com/datben/jni-test/blob/master/project/plugins.sbt#L1 |
@pomadchin lIt looks fine on my side, but perhaps you could consider adding a parameter to allow or disallow multiple outputs (defaulting to false) to avoid it being potentially a breaking change |
10c68b5
to
c0d88ef
Compare
…elease so there is no implicit behavior change
c0d88ef
to
aadaa65
Compare
@datben makes sense 👍 Added a new key: nativeMultipleOutputs := {false | true} // false by default |
This PR modifies all build tools behavior to put all the possible project outputs into the res artifact.
See #185 (comment)
Closes #185
@datben could you check if it works for you?
I'll try it on my repos as well later to ensure that nothing is broken with this change.