Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[General] common.plot_cytobands and matplotlib 3.9.0 deprecation #71

Closed
theAeon opened this issue Jun 6, 2024 · 1 comment · Fixed by #72
Closed

[General] common.plot_cytobands and matplotlib 3.9.0 deprecation #71

theAeon opened this issue Jun 6, 2024 · 1 comment · Fixed by #72
Labels
bug Something isn't working

Comments

@theAeon
Copy link

theAeon commented Jun 6, 2024

Looks like api/common.py imports BrokenBarHCollection from matplotlib.collections. This was removed in the last matplotlib release. Should be an easy swap to fill_between if their release notes page is to be believed.

@sbslee sbslee added the bug Something isn't working label Jun 15, 2024
@sbslee
Copy link
Owner

sbslee commented Jun 15, 2024

@theAeon,

Thank you for reporting the issue. Contrary to the release notes, simple swapping did not work. This issue is actually a critical one since it makes the entire fuc package incompatible with the latest matplotlib package.

I currently don't have the capacity to fix the problem, so I will deprecate the common.plot_cytobands method starting with the 0.38.0 release, especially since it was not used by many people anyway.

@sbslee sbslee closed this as completed Jun 15, 2024
@sbslee sbslee changed the title matplotlib 3.9.0 deprecation [General] matplotlib 3.9.0 deprecation Jun 15, 2024
@sbslee sbslee changed the title [General] matplotlib 3.9.0 deprecation [General] common.plot_cytobands and matplotlib 3.9.0 deprecation Jun 15, 2024
@sbslee sbslee linked a pull request Jun 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants