-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packaging improvements #700
Open
chayleaf
wants to merge
5
commits into
sbs20:master
Choose a base branch
from
chayleaf:packaging-improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chayleaf
force-pushed
the
packaging-improvements
branch
9 times, most recently
from
November 18, 2023 18:16
c1aee70
to
bf41a95
Compare
I've now verified that this works (except the Debian package) and am running this version |
chayleaf
force-pushed
the
packaging-improvements
branch
5 times, most recently
from
November 19, 2023 10:21
1b964b8
to
98eb0f0
Compare
tests/lints pass on all commits now, and I've separated the changes into commits a bit better |
chayleaf
force-pushed
the
packaging-improvements
branch
from
November 20, 2023 09:22
98eb0f0
to
6a8b221
Compare
Thanks for this! There's a lot to review here. I will get to it when I can. |
12 tasks
@sbs20 any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see #695)
partially fixes #629 (the initial config is built before loading user options, so the initial config still uses convert from PATH)
This fixes what I consider not following the best packaging practices. Namely:
data
andconfig
in its directory, even if those are symlinks. Best practice is for any paths to runtime state to be completely decoupled from whatever is in /usr.config
symlink, which is a very bad solution.