Bug fix diameter calculation error #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description
The craters' diameters might go wrong when project CRS is inconsistent with layer CRS. For example the crater diameter failed to convert to meters when layer CRS is geographic coordinate system while the project CRS is a projected coordinate system.
Current state
Now circle-craters can work correctly when layer CRS / project CRS are both projected or project CRS is projected with geographic layer CRS.
Known issue
When project CRS is geographic and layer CRS is projected, one might get wrong diameter measurement. But this CRS situation should be avoid since one would need projected CRS to preform accurate measurement. And thanks to On-The-Fly Projection, we can get a projected view by only set project CRS to projected, regardless of layer CRS.
Miscellaneous
script cleanup: