Fixing Public Comments checkbox in Settings #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The corresponding checkbox now will be checked if Public Comments is enabled. Fixing for commit d078fe7
rumblefrog
added
semver: patch
t: permission system
t: ui/ux
template: used
rumblefrog
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The corresponding checkbox now will be checked if Public Comments is enabled.
Fixing for commit d078fe7
Motivation and Context
The checkbox for Public Comments wasn't checked even if the setting was enabled.
How Has This Been Tested?
I have previously enabled Public Comments, and with this change the checkbox is checked showing that I have Public Comments already enabled.
Screenshots (if appropriate):
Types of changes
Checklist: