Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spelling for 'permanent' #582

Closed
wants to merge 1 commit into from
Closed

Fix spelling for 'permanent' #582

wants to merge 1 commit into from

Conversation

geominorai
Copy link
Contributor

Fixes hardcoded typo: permament -> permanent

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@CrazyHackGUT
Copy link
Contributor

CrazyHackGUT commented Jul 22, 2019 •
edited
Loading

This phrase don't should be hardcoded (on all languages, we can got string like:

Вы были забанены на этом сервере, ...
...
Length: permanent

).

I think, it should be moved to .phrases.txt file.

@rumblefrog rumblefrog mentioned this pull request Sep 25, 2019
Merged
7 tasks
@geominorai geominorai deleted the patch/spelling_permanent branch September 26, 2019 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
s: superceded t: plugin t: translations type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geominorai @CrazyHackGUT @rumblefrog