Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updater rework #458

Merged
merged 6 commits into from
May 2, 2018
Merged

Updater rework #458

merged 6 commits into from
May 2, 2018

Conversation

Groruk
Copy link
Member

@Groruk Groruk commented May 2, 2018

Description

  • Reworked updater to use a new Updater class.
  • Fixed template issues
  • All Updates now use PDO instead of ADODB
  • Charset is now passed as parameter for Database class
  • Removed update support for SourceBans RC versions

@sbpp sbpp deleted a comment May 2, 2018
@sbpp sbpp deleted a comment May 2, 2018
@sbpp sbpp deleted a comment May 2, 2018
@sbpp sbpp deleted a comment May 2, 2018
@Groruk Groruk merged commit 61117cc into sbpp:v1.x May 2, 2018
@Groruk Groruk deleted the Updater-Rework branch May 2, 2018 08:08
@Bara
Copy link

Bara commented May 2, 2018

Any reason why you set the default charset to utf8 but here https://github.com/sbpp/sourcebans-pp/pull/458/files#diff-8bdf163b47c46dcc7485c0e0a0370224R15 to utf8mb4? It's a bit confusing

@Groruk
Copy link
Member Author

Groruk commented May 2, 2018

All update files are for older SourceBans or SourceBans++ versions to update (utf8mb4 support was officially added in 1.6.0 (update file 600)) so every update before that will still be utf8 (just for compatibility reason).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants