-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to record tree #11
Conversation
.filter {$0.tagId == HwpDocInfoTag.binData} | ||
.map {try HwpBinData($0.payload)} | ||
|
||
faceNameArray = try record.children |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 7 locations. Consider refactoring.
.filter {$0.tagId == HwpDocInfoTag.faceName} | ||
.map {try HwpFaceName($0.payload)} | ||
|
||
borderFillArray = try record.children |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 7 locations. Consider refactoring.
.filter {$0.tagId == HwpDocInfoTag.borderFill} | ||
.map {try HwpBorderFill($0.payload)} | ||
|
||
charShapeArray = try record.children |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
.filter {$0.tagId == HwpDocInfoTag.charShape} | ||
.map {try HwpCharShape($0.payload, version)} | ||
|
||
paraShapeArray = try record.children |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
|
||
guard let documentProperties = records | ||
guard let documentProperties = record.children |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
.filter {$0.tagId == HwpDocInfoTag.paraShape} | ||
.map {try HwpParaShape($0.payload, version)} | ||
} | ||
guard let idMappings = record.children |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Code Climate has analyzed commit 7c27f4a and detected 25 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
No description provided.