Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to record tree #11

Merged
merged 11 commits into from
Oct 10, 2020
Merged

Change to record tree #11

merged 11 commits into from
Oct 10, 2020

Conversation

sboh1214
Copy link
Owner

No description provided.

.filter {$0.tagId == HwpDocInfoTag.binData}
.map {try HwpBinData($0.payload)}

faceNameArray = try record.children
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 7 locations. Consider refactoring.

.filter {$0.tagId == HwpDocInfoTag.faceName}
.map {try HwpFaceName($0.payload)}

borderFillArray = try record.children
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 7 locations. Consider refactoring.

.filter {$0.tagId == HwpDocInfoTag.borderFill}
.map {try HwpBorderFill($0.payload)}

charShapeArray = try record.children
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

.filter {$0.tagId == HwpDocInfoTag.charShape}
.map {try HwpCharShape($0.payload, version)}

paraShapeArray = try record.children
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.


guard let documentProperties = records
guard let documentProperties = record.children
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

.filter {$0.tagId == HwpDocInfoTag.paraShape}
.map {try HwpParaShape($0.payload, version)}
}
guard let idMappings = record.children
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Oct 10, 2020

Code Climate has analyzed commit 7c27f4a and detected 25 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 5
Duplication 20

View more on Code Climate.

@sboh1214 sboh1214 merged commit 30fa2f8 into main Oct 10, 2020
@sboh1214 sboh1214 deleted the change/recordTree branch October 10, 2020 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant