Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment cycle optimization #377

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Conversation

fbergmann
Copy link
Member

Description

This PR optimizes the determination of assignment cycle dependencies by avoiding to copy elements and using equal_range and early return when an existing edge was determined.

Motivation and Context

Drastically improves speed of the assignment cycle determination. fixes #374

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

@fbergmann fbergmann requested a review from skeating May 26, 2024 12:26
@fbergmann
Copy link
Member Author

the reported test failure on macOS is unrelated (has to do with the C# tests not working with the latest macOS version).

@fbergmann fbergmann merged commit 927ed06 into development Aug 1, 2024
27 of 35 checks passed
@skeating skeating deleted the assignment-cycle-optimization branch August 18, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the efficiency of the AssignmentCycles::determineAllDependencies() function
2 participants