Skip to content

Commit

Permalink
change operation from mul to minus to show incorrect results for this…
Browse files Browse the repository at this point in the history
… case
  • Loading branch information
lkeegan authored and fbergmann committed Mar 14, 2023
1 parent b51d7ca commit 14bef1f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions src/sbml/test/TestSBMLTransforms.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,9 @@ START_TEST (test_SBMLTransforms_replaceFD)
safe_free(math);

/* https://github.com/sbmlteam/libsbml/issues/299 */
/* fd: f_relabelled(p, S1) = p * S1 */
/* fd: f_relabelled(p, S1) = p - S1 */
/* ast: f_relabelled(S1, p) * compartmentOne / t */
/* ast after replaceFD: p * S1 * compartmentOne / t */
/* ast after replaceFD: (S1 - p) * compartmentOne / t */

// use initial assignment instead of reaction, because the reaction
// got flagged as having invalid units
Expand All @@ -114,7 +114,7 @@ START_TEST (test_SBMLTransforms_replaceFD)
SBMLTransforms::replaceFD(&ast, fd);

math = SBML_formulaToString(&ast);
fail_unless (!strcmp(math, "p * S1 * compartmentOne / t"), NULL);
fail_unless (!strcmp(math, "(S1 - p) * compartmentOne / t"), NULL);
safe_free(math);

/* one function definition - nested */
Expand Down
2 changes: 1 addition & 1 deletion src/sbml/test/test-data/multiple-functions.xml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
<ci> S1 </ci>
</bvar>
<apply>
<times/>
<minus/>
<ci> p </ci>
<ci> S1 </ci>
</apply>
Expand Down

0 comments on commit 14bef1f

Please sign in to comment.