Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTN better split the linting process from the CI/CD workflow #1164

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

tomMoral
Copy link
Contributor

@tomMoral tomMoral commented Jun 6, 2024

  • Separate workflow for the linting.
  • Move pyright in dedicated process to avoid failing the test on type checks.

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.94%. Comparing base (1b268b8) to head (46dd175).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1164       +/-   ##
===========================================
- Coverage   83.08%   72.94%   -10.14%     
===========================================
  Files          92       93        +1     
  Lines        7259     7371      +112     
===========================================
- Hits         6031     5377      -654     
- Misses       1228     1994      +766     
Flag Coverage Δ
unittests 72.94% <ø> (-10.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 23 files with indirect coverage changes

@tomMoral
Copy link
Contributor Author

This is part of the changes that were proposed in #1008 .
For the failure, I think it is something that is already on the main branch no?

Copy link
Contributor

@janfb janfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this makes sense, thanks! I added one question.

Yes, pyright is failing atm, see #1162 . Probably due to a pyright update? But certainly unrelated to this branch.

@janfb janfb merged commit 66d1f2b into sbi-dev:main Jun 10, 2024
5 of 6 checks passed
@janfb janfb deleted the MTN_split_ci branch June 10, 2024 19:04
manuelgloeckler added a commit that referenced this pull request Jun 14, 2024
* Base estimator class

* MTN: split linting process from the CI/CD workflow (#1164)

* Apply suggestions from code review

Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>

* Formating

* Base estimator class

* Apply suggestions from code review

Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>

* Formating

* ConditionalDensityEstimator renaming

* Apply suggestions from code review

Co-authored-by: Jan <janfb@users.noreply.github.com>

* suggestions

* Fixing missing loss in SNPE_A

---------

Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
Co-authored-by: Jan <janfb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants