Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forms and exceptions improvements #259

Merged
merged 9 commits into from
Aug 20, 2024
Merged

Forms and exceptions improvements #259

merged 9 commits into from
Aug 20, 2024

Conversation

noelleleigh
Copy link

  • Removed some unnecessary = ... on class attributes (see typing docs)
  • Added new exceptions to django.core.exceptions
  • Added more specific types to ValidationError
  • Gave BaseForm its parent class and made BaseForm.fields more specific
  • Moved the _meta attribute from BaseForm to ModelForm
  • Gave Form its metaclass and marked its attributes as class variables
  • Improved type for ModelFormOptions.formfield_callback
  • forms.utils: Added new classes, polished types on existing ones

sbdchd
sbdchd approved these changes Aug 20, 2024
View reviewed changes
Copy link
Owner

@sbdchd sbdchd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@kodiakhq kodiakhq bot merged commit 84064af into sbdchd:main Aug 20, 2024
2 checks passed
@noelleleigh noelleleigh deleted the forms-improvements branch August 20, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbdchd sbdchd sbdchd approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noelleleigh @sbdchd