Skip to content

Commit

Permalink
Update the minimum supported build-time version of node to 16.20.0
Browse files Browse the repository at this point in the history
For the minimum build-time version of node we bump 10.19.0 -> 16.20.0

This new minimum version matches the version that we ship with emsdk.
Critically it supports null coalescing & logical assignment needed
by emscripten-core#20549.
  • Loading branch information
sbc100 committed Oct 30, 2023
1 parent bb9c4ce commit e325726
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 7 deletions.
5 changes: 5 additions & 0 deletions ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@ See docs/process.md for more on how version tagging works.

3.1.48 (in development)
-----------------------
- The minimum version of node required run the compiler was updated from
10.19 to 16.20. The minimum verison of node supported by the
emscripten-generated code was updated from 15.0 to 16.20. One side effect of
this is that the `NODEJS_CATCH_REJECTION` settings is no longer relevant and
is now ignored. (#20551)
- A new top-level `bootstrap` script was added. This script is for emscripten
developers and helps take a care of post-checkout tasks such as `npm install`.
If this script needs to be run (e.g. becuase package.json was changed, emcc
Expand Down
4 changes: 2 additions & 2 deletions test/test_sanity.py
Original file line number Diff line number Diff line change
Expand Up @@ -281,8 +281,8 @@ def test_node(self):
for version, succeed in [('v0.8.0', False),
('v4.1.0', False),
('v10.18.0', False),
('v10.19.0', True),
('v10.19.1-pre', True),
('v16.20.0', True),
('v16.20.1-pre', True),
('cheez', False)]:
print(version, succeed)
delete_file(SANITY_FILE)
Expand Down
11 changes: 6 additions & 5 deletions tools/shared.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,12 @@
PRINT_SUBPROCS = int(os.getenv('EMCC_VERBOSE', '0'))
SKIP_SUBPROCS = False

# Minimum node version required to run the emscripten compiler. This is distinct
# from the minimum version required to execute the generated code. This is not an
# exact requirement, but is the oldest version of node that we do any testing with.
# This version aligns with the current Ubuuntu TLS 20.04 (Focal).
MINIMUM_NODE_VERSION = (10, 19, 0)
# Minimum node version required to run the emscripten compiler. This is
# distinct from the minimum version required to execute the generated code
# (settings.MIN_NODE_VERSION).
# This version currently matches the node version that we ship with emsdk
# which means that we can say for sure that this version is well supported.
MINIMUM_NODE_VERSION = (16, 20, 0)
EXPECTED_LLVM_VERSION = 18

# These get set by setup_temp_dirs
Expand Down

0 comments on commit e325726

Please sign in to comment.