Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Page error "Incorrect use of <label for=FORM_ELEMENT>" #1918

Closed
3 tasks done
railwayursin opened this issue Jun 13, 2023 · 2 comments · Fixed by #2258
Closed
3 tasks done

[Bug]: Page error "Incorrect use of <label for=FORM_ELEMENT>" #1918

railwayursin opened this issue Jun 13, 2023 · 2 comments · Fixed by #2258
Labels
bug Something isn't working comp: angular Issues related to @sbb-esta/angular effort1: hours prio4: low Should be done after all higher priorities are done wontfix This will not be worked on

Comments

@railwayursin
Copy link

Preflight Checklist

Bug type

Other

Which version are you using

16.1.0

Operating system

Windows 10

Browser / Browser version

Chrome 114.0.5735.110

Input mode

Mouse/Keyboard

Additional settings

What happened?

After the recent chrome update (version 114.0.5735.110) the devtools display page errors for the select component "Incorrect use of ".

Steps to reproduce the issue

  1. Open the chrome devtools
  2. Navigate to select examples page select

A red flag icon with a number will be displayed and a issues tab with the error message.

Relevant log output

No response
@railwayursin railwayursin added the bug Something isn't working label Jun 13, 2023
@mhaertwig mhaertwig added prio4: low Should be done after all higher priorities are done comp: angular Issues related to @sbb-esta/angular effort1: hours labels Jun 13, 2023
@mhaertwig
Copy link
Collaborator

mhaertwig commented Jun 14, 2023 •
edited
Loading

Related to angular/components#27241

@railwayursin do you experience any accessibility issues related to this? I am not sure if fixing this is worth the effort and I also don't see the benefit of adding an option to turn the label in a standard div as suggested in the linked issue. I suggest to not fix this issue. What do you think?

My findings:

@mhaertwig mhaertwig added the wontfix This will not be worked on label Jul 5, 2023
@mhaertwig
Copy link
Collaborator

@railwayursin I marked this issue as wontfix and close it. Feel free to re-open if you experience any accessibility issues.

mhaertwig added a commit that referenced this issue May 1, 2024
@mhaertwig
fix(multiple): remove label for attribute on non-native elements
baa1da0 
Adds an option to remove the `for` attribute from the `<label>` inside the form field from elements that can't be labeled. Also applies the new option to `sbb-select` and `sbb-textarea`. This isn't an accessibility regression, because those elements were already being labeled using `aria-labelledby`.
Fixes #1918
mhaertwig added a commit that referenced this issue May 2, 2024
@mhaertwig
fix(multiple): remove label for attribute on non-native elements
f2b74dc 
Adds an option to remove the `for` attribute from the `<label>` inside the form field from elements that can't be labeled. Also applies the new option to `sbb-select` and `sbb-textarea`. This isn't an accessibility regression, because those elements were already being labeled using `aria-labelledby`.
Fixes #1918
@mhaertwig mhaertwig mentioned this issue May 2, 2024
Merged
mhaertwig added a commit that referenced this issue May 7, 2024
@mhaertwig
fix(multiple): remove label for attribute on non-native elements (#2258)
1032655 
Adds an option to remove the `for` attribute from the `<label>` inside the form field from elements that can't be labeled. Also applies the new option to `sbb-select` and `sbb-textarea`. This isn't an accessibility regression, because those elements were already being labeled using `aria-labelledby`.
Fixes #1918
sbb-design-systems-bot bot pushed a commit that referenced this issue May 7, 2024
@mhaertwig
fix(multiple): remove label for attribute on non-native elements (#2258)
6fae011 
Adds an option to remove the `for` attribute from the `<label>` inside the form field from elements that can't be labeled. Also applies the new option to `sbb-select` and `sbb-textarea`. This isn't an accessibility regression, because those elements were already being labeled using `aria-labelledby`.
Fixes #1918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working comp: angular Issues related to @sbb-esta/angular effort1: hours prio4: low Should be done after all higher priorities are done wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(multiple): remove label for attribute on non-native elements sbb-design-systems/sbb-angular
2 participants
@mhaertwig @railwayursin