Feature: Add NTLM support for CURB #144
Merged
+35
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -59,10 +59,11 @@ def do_request | |||
| def setup_client | |||
| basic_setup | |||
|
|
|||
| if @request.auth.ntlm? | |||
| if @request.auth.ntlm? && !Curl.ntlm? | |||
| raise NotSupportedError, "curb does not support NTLM authentication" | |||
There was a problem hiding this comment.
It'd be great to tell on this message what curb's version support it, just to help the developer.
|
Hi @plainprogrammer! @tjarratt after the merge we update the changelog? We have a kind of process for this? |
The support issue is with the underlying version of libcurl, not Curb itself. This messaging makes that more clear.
|
@rogerleite that sounds right. I'm not opposed to having contributors update the changelog, but I try to either
|
|
cURL, 7.10.6 - July 28 2003, adds support to NTLM authentication. http://curl.haxx.se/changes.html I'll merge and update error message and changelog. |
rogerleite
added a commit
that referenced
this pull request
Jun 18, 2015
Feature: Add NTLM support for CURB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My changes now only raise the not supported error if the available libcurl library used by CURB doesn't have NTLM support. New versions of libcurl should allow for NTLM to be used with CURB, which is a big win for HTTPI.