Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update auto-reload.js possible minor issue #104

Merged
merged 1 commit into from Jun 17, 2013
Merged

Update auto-reload.js possible minor issue #104

merged 1 commit into from Jun 17, 2013

Conversation

ghost
Copy link

@ghost ghost commented Mar 20, 2013

check if viewing a thread or viewing a board page when updating a thread so new posts do not appear at bottom of page while viewing threads list not sure if this was because of an outdated template but I thought I should point out this as it may affect html templates no matter the code as the banner code is the only code that checks where the user currently is.

check if viewing a thread or viewing a board page when updating a thread so new posts do not appear at bottom of page while viewing threads list not sure if this was because of an outdated template but I thought I should point out this as it may affect html templates no matter the code as the banner code is the only code that checks where the user currently is.
savetheinternet pushed a commit that referenced this pull request Jun 17, 2013
Update auto-reload.js possible minor issue
@savetheinternet savetheinternet merged commit 81b3eec into savetheinternet:master Jun 17, 2013
@MacilPrime
Copy link
Contributor

Does the if($('div.banner').length == 0) return; check right above it already accomplish this?

@ghost
Copy link
Author

ghost commented Jun 19, 2013

"Does the if($('div.banner').length == 0) return; check right above it already accomplish this?"
Yes but there is a banner while viewing both a threads page and the threads index so checking if the banner is there or not is only good for pages with the auto-reply.js script running on a page which doesn't have a banner

@MacilPrime
Copy link
Contributor

The div.banner element isn't present on the thread index page (at least not in the current version anyway). Furthermore, checking for the presence of a single .post.op element will still succeed on thread index pages and mod.php?/IP/ pages where there is only one thread OP.

Circlepuller pushed a commit to Circlepuller/Tinyboard that referenced this pull request Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants