Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test suite source validation #1096

Closed
4 of 10 tasks
petertrr opened this issue Aug 24, 2022 · 1 comment · Fixed by #1778, #1810, #1955 or #1956
Closed
4 of 10 tasks

Test suite source validation #1096

petertrr opened this issue Aug 24, 2022 · 1 comment · Fixed by #1778, #1810, #1955 or #1956
Assignees
@0x6675636b796f75676974687562
Labels
enhancement New feature or request

Comments

@petertrr
Copy link
Member

petertrr commented Aug 24, 2022 •
edited by 0x6675636b796f75676974687562
Loading

After test suite source is fetched, we should store and display validations, including among others:

  • Whether source contains suites with plugins that have zero tests
  • Whether source contains suites with wildcard mode (not handled well by save-cloud currently?)

This includes calculating these validations, storing them in the storage and support them on the frontend

Tasks, as discussed with @nulls:

  • Front-end
  • Back-end
    • TBD
  • Preprocessor
    • Wrap blocking operations into blockingToMono {} #1778
    • Implement test suite validators on the preprocessor side #1955
    • Get rid of type aliases #1956
    • Refactor TestSuitesPreprocessorController#doFetchTests() and the underlying calls
      • The snapshot should be always saved (TestPreprocessorToBackendBridge#saveTestsSuiteSourceSnapshot()), even in case of validation errors. This is necessary, so that a malformed snapshot is never re-fetched again.
      • The tests_source_snapshot table, along with the corresponding DTO, should be enriched with isSuccessful and errorMessage fields
      • TestDiscoveringService#detectAndSaveAllTestSuitesAndTests() should perform the following operations, in order:
        1. detect test suites and tests
        2. validate test suites and tests
        3. update the saved snapshot with status and error messages, if any
        4. save test suites and tests, if the validation succeeded
@petertrr petertrr added the enhancement New feature or request label Aug 24, 2022
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 moved this from 📋 Backlog to 🏗 In progress in VULN and SAVE: OCT-NOV Jan 19, 2023
Merged
0x6675636b796f75676974687562 added a commit that referenced this issue Feb 9, 2023
@0x6675636b796f75676974687562
Implement the useEventStream() (SSE, HTTP GET only) and `useNewline…
903b51a 
…DelimitedJson()` _React_ hooks

### What's done:

 - This change allows live event streaming from the back-end (`Flux<T>` or
   `ParallelFlux<T>`) to the font-end, using either `text/event-stream`
   (arbitrary text data, incl. JSON) or `application/x-ndjson` (JSON only).
 - On the server side, _Spring_ has support for both content types.
 - This is a part of #1096.
0x6675636b796f75676974687562 added a commit that referenced this issue Feb 9, 2023
@0x6675636b796f75676974687562
Implement the useEventStream() (SSE, HTTP GET only) and `useNewline…
404a28f 
…DelimitedJson()` _React_ hooks

### What's done:

 - This change allows live event streaming from the back-end (`Flux<T>` or
   `ParallelFlux<T>`) to the font-end, using either `text/event-stream`
   (arbitrary text data, incl. JSON) or `application/x-ndjson` (JSON only).
 - On the server side, _Spring_ has support for both content types.
 - This is a part of #1096.
0x6675636b796f75676974687562 added a commit that referenced this issue Feb 9, 2023
@0x6675636b796f75676974687562
Implement the useEventStream() (SSE, HTTP GET only) and `useNewline…
fa08f2a 
…DelimitedJson()` _React_ hooks (#1810)

### What's done:

 - This change allows live event streaming from the back-end (`Flux<T>` or
   `ParallelFlux<T>`) to the font-end, using either `text/event-stream`
   (arbitrary text data, incl. JSON) or `application/x-ndjson` (JSON only).
 - On the server side, _Spring_ has support for both content types.
 - This is a part of #1096.
This was linked to pull requests Feb 9, 2023
Wrap blocking operations into blockingToMono {} #1778
Merged
Implement the useEventStream() (SSE, HTTP GET only) and useNewlineDelimitedJson() React hooks #1810
Merged
Draft
0x6675636b796f75676974687562 added a commit that referenced this issue Mar 7, 2023
@0x6675636b796f75676974687562
Get rid of type aliases
4df2a8c 
 - This converts `CloneAndProcessDirectoryAction`, `GitRepositoryProcessor`,
   and `CloneResult` into classes/interfaces.
 - Additionally, `fetch()` now returns a `Flux<TestSuiteValidationResult>`
   instead of `Mono<Unit>`.
 - Related: #1096
0x6675636b796f75676974687562 added a commit that referenced this issue Mar 7, 2023
@0x6675636b796f75676974687562
Add the initial implementation on the preprocessor side
4481d6a 
Related: #1096

Dummy
This was referenced Mar 7, 2023
Merged
Merged
0x6675636b796f75676974687562 added a commit that referenced this issue Mar 9, 2023
@0x6675636b796f75676974687562
Add the initial implementation on the preprocessor side (#1955)
c1a0609 
 - Related: #1096
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 linked a pull request Mar 9, 2023 that will close this issue
Implement test suite validators on the preprocessor side #1955
Merged
0x6675636b796f75676974687562 added a commit that referenced this issue Mar 9, 2023
@0x6675636b796f75676974687562
Get rid of type aliases (#1956)
e06acc0 
- This converts `CloneAndProcessDirectoryAction`, `GitRepositoryProcessor`,
   and `CloneResult` into classes/interfaces.
 - Additionally, `fetch()` now returns a `Flux<TestSuiteValidationResult>`
   instead of `Mono<Unit>`.
 - Related: #1096
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 linked a pull request Mar 9, 2023 that will close this issue
Get rid of type aliases #1956
Merged
@orchestr7 orchestr7 unpinned this issue May 26, 2023
@orchestr7
Copy link
Member

Andrey did a lot of related things, probably we will open a new issue, when needed

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in VULN and SAVE: OCT-NOV Jun 28, 2023
0x6675636b796f75676974687562 added a commit that referenced this issue Oct 31, 2024
@0x6675636b796f75676974687562
Add the initial implementation on the preprocessor side
5817a99 
Related: #1096

Dummy
0x6675636b796f75676974687562 added a commit that referenced this issue Oct 31, 2024
@0x6675636b796f75676974687562
Get rid of type aliases
4b074a5 
 - This converts `CloneAndProcessDirectoryAction`, `GitRepositoryProcessor`,
   and `CloneResult` into classes/interfaces.
 - Additionally, `fetch()` now returns a `Flux<TestSuiteValidationResult>`
   instead of `Mono<Unit>`.
 - Related: #1096
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0x6675636b796f75676974687562 0x6675636b796f75676974687562

Labels
enhancement New feature or request
Projects
VULN and SAVE: OCT-NOV
Status: ✅ Done
Milestone
No milestone
3 participants
@petertrr @orchestr7 @0x6675636b796f75676974687562