Support KDoc generation for rethrown exceptions #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Changed logic * Added tests
Codecov Report
@@ Coverage Diff @@
## master #990 +/- ##
============================================
- Coverage 83.85% 83.80% -0.05%
- Complexity 2416 2422 +6
============================================
Files 102 102
Lines 6094 6108 +14
Branches 1802 1809 +7
============================================
+ Hits 5110 5119 +9
Misses 269 269
- Partials 715 720 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: * Changed logic * Added tests
kgevorkyan
approved these changes
Jul 20, 2021
| println("Whoops...") | ||
| throw e | ||
| } catch (e: Error) { | ||
| val x = IllegalStateException() |
There was a problem hiding this comment.
May be create issue on subject to improve missingExceptions detection to cover this case? When exception throws via local variable?
Or at least add TODO in code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #975
Fixme:
val x = IllegalStateException(); throw x