Bugfix of NPE in complex binary expressions in long line rule #983
Conversation
Codecov Report
@@ Coverage Diff @@
## master #983 +/- ##
=========================================
Coverage 83.81% 83.81%
- Complexity 2407 2409 +2
=========================================
Files 102 102
Lines 6079 6081 +2
Branches 1797 1799 +2
=========================================
+ Hits 5095 5097 +2
Misses 269 269
Partials 715 715
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Despite the fact, that for now we get rid of NPE and cover this case by tests, we still have issue on related functionality #984 I think, we can consider it in future PR |
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/LineLength.kt
Outdated
Show resolved
Hide resolved
| if (it.elementType == REFERENCE_EXPRESSION && it.treeParent.elementType == CALL_EXPRESSION) { | ||
| binList.add(it.treeParent) | ||
| if (it.elementType == REFERENCE_EXPRESSION && it.treeParent?.elementType == CALL_EXPRESSION) { | ||
| binList.tryAdd(it.treeParent) |
There was a problem hiding this comment.
Did we add the same element multiple times here? How could it be?
There was a problem hiding this comment.
Yeah, thanks, I did a lot of experiments with dfsForProperty and it's remain from them, now it's not necessary, removed.
What's done:
binListcould hold incorrect nodes, which had nobinary expressionas first common parent