Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package naming: Allow default package in kotlin files in buildSrc #947

Merged
merged 4 commits into from
Jul 1, 2021

Conversation

Cheshiriks
Copy link
Member

What's done:

What's done:
* Disabled rule for buildSrc directory
Closes #915
@Cheshiriks Cheshiriks force-pushed the feature/filePath-contains-buildSrc branch from ba497c7 to 81cc27e Compare June 30, 2021 21:46
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests

### What's done:
* Disabled rule for buildSrc directory
Closes #915
### What's done:
* Disabled rule for buildSrc directory
Closes #915
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #947 (d80e82c) into master (d584b2a) will increase coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #947   +/-   ##
=========================================
  Coverage     84.12%   84.12%           
- Complexity     2388     2389    +1     
=========================================
  Files           101      101           
  Lines          6027     6029    +2     
  Branches       1781     1782    +1     
=========================================
+ Hits           5070     5072    +2     
  Misses          263      263           
  Partials        694      694           
Flag Coverage Δ
unittests 84.12% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...qfn/diktat/ruleset/rules/chapter1/PackageNaming.kt 91.08% <85.71%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d584b2a...d80e82c. Read the comment docs.

### What's done:
* Disabled rule for buildSrc directory
Closes #915
@Cheshiriks Cheshiriks merged commit 0786d51 into master Jul 1, 2021
@petertrr petertrr deleted the feature/filePath-contains-buildSrc branch July 1, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package naming: Allow default package in kotlin files in buildSrc
2 participants