-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NPE in KdocFormatting rule #876
Conversation
### What's done: * Updated logic * Added tests
### What's done: * Updated logic * Added tests
### What's done: * Updated logic * Added tests
Codecov Report
@@ Coverage Diff @@
## master #876 +/- ##
============================================
- Coverage 83.61% 83.53% -0.09%
- Complexity 2208 2210 +2
============================================
Files 101 101
Lines 5669 5677 +8
Branches 1614 1620 +6
============================================
+ Hits 4740 4742 +2
Misses 256 256
- Partials 673 679 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What's done:
We were treating any blank line in KDoc tag's body as an error and were trying to remove it, while empty lines between tag's lines are valid.
TODO:
This pull request closes #868