Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use github packages for kotlin-maven-plugin-tools #835

Merged
merged 5 commits into from
Apr 19, 2021

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Apr 19, 2021

What's done:

  • Changed pluginRepositories in pom.xml
  • Update CI workflows
  • Added notes in README.md

Background: this plugin has been available only in bintray, which will be shut down soon. As discussed in gantsign/kotlin-maven-plugin-tools#293, the plugin is for now moved to github packages, because there are some difficulties to move to Maven Cenral.

@petertrr petertrr force-pushed the infra/kotlin-maven-plugin-tools-gh-packages branch from 2643147 to 16a1ae7 Compare April 19, 2021 09:17
### What's done:
* Changed pluginRepositories in pom.xml
* Update CI workflows
* Added notes in README.md
@petertrr petertrr force-pushed the infra/kotlin-maven-plugin-tools-gh-packages branch from 16a1ae7 to 5d56e4c Compare April 19, 2021 09:22
### What's done:
* Changed pluginRepositories in pom.xml
* Update CI workflows
* Added notes in README.md
### What's done:
* Changed pluginRepositories in pom.xml
* Update CI workflows
* Added notes in README.md
@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #835 (d40b51f) into master (292ee58) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #835   +/-   ##
=========================================
  Coverage     80.98%   80.98%           
  Complexity     2289     2289           
=========================================
  Files           100      100           
  Lines          5833     5833           
  Branches       1813     1813           
=========================================
  Hits           4724     4724           
  Misses          286      286           
  Partials        823      823           
Flag Coverage Δ Complexity Δ
unittests 80.98% <ø> (ø) 2289.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 292ee58...d40b51f. Read the comment docs.

### What's done:
* Changed pluginRepositories in pom.xml
* Update CI workflows
* Added notes in README.md
### What's done:
* Changed pluginRepositories in pom.xml
* Update CI workflows
* Added notes in README.md
@petertrr petertrr marked this pull request as ready for review April 19, 2021 11:06
@petertrr petertrr merged commit d8aafa4 into master Apr 19, 2021
@petertrr petertrr deleted the infra/kotlin-maven-plugin-tools-gh-packages branch April 19, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants