Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom source directories #778

Merged
merged 10 commits into from
Feb 20, 2021
Merged

Allow custom source directories #778

merged 10 commits into from
Feb 20, 2021

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented Feb 16, 2021

What's done:

Added new configuration param
closes #773

### What's done:
   Added new configuration param
@kentr0w kentr0w added the enhancement New feature or request label Feb 16, 2021
@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #778 (6c725ca) into master (517e3d6) will decrease coverage by 0.09%.
The diff coverage is 38.46%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #778      +/-   ##
============================================
- Coverage     81.28%   81.19%   -0.10%     
  Complexity     2148     2148              
============================================
  Files            97       97              
  Lines          5542     5551       +9     
  Branches       1706     1709       +3     
============================================
+ Hits           4505     4507       +2     
- Misses          271      278       +7     
  Partials        766      766              
Flag Coverage Δ Complexity Δ
unittests 81.19% <38.46%> (-0.10%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...fn/diktat/common/config/rules/RulesConfigReader.kt 34.61% <11.11%> (-4.03%) 4.00 <0.00> (ø)
...qfn/diktat/ruleset/rules/chapter1/PackageNaming.kt 92.04% <100.00%> (+0.09%) 36.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 517e3d6...6c725ca. Read the comment docs.

### What's done:
   Fixed after review
### What's done:
   Fixed bug with configuration
### What's done:
   Added info into documentation
### What's done:
   Fixed according to our code style
  Fixed according to our code style
diktat-analysis.yml Outdated Show resolved Hide resolved
info/guide/guide-chapter-1.md Outdated Show resolved Hide resolved
Fixed according to our code style
### What's done:
Fixed after review
@kentr0w kentr0w merged commit c80bc50 into master Feb 20, 2021
@kentr0w kentr0w deleted the feature/custom-src-dir branch February 20, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow custom source directory names, like nativeMain
2 participants