Bugfix. Indentation inside string templates(#758) #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Added a simple test
### What's done: * Fixed bugs * Added tests
Codecov Report
@@ Coverage Diff @@
## master #765 +/- ##
============================================
- Coverage 80.56% 80.49% -0.07%
- Complexity 2044 2046 +2
============================================
Files 97 97
Lines 5300 5307 +7
Branches 1637 1640 +3
============================================
+ Hits 4270 4272 +2
- Misses 247 250 +3
- Partials 783 785 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kentr0w
requested changes
Feb 11, 2021
| |fun foo(some: String) { | ||
| | fun bar() { | ||
| | val a = "${'$'}{ | ||
| | expression |
There was a problem hiding this comment.
I corrected expression as it should be, but then it incorrectly detects the indentation of the bottom lines
petertrr
approved these changes
Feb 11, 2021
### What's done: * New bug with warn (fix work fine)
orchestr7
approved these changes
Feb 15, 2021
### What's done: * Fixed bug
### What's done: * Fixed bug
### What's done: * Fixed bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #758
Actions checklist