Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix. False positives in UNUSED_IMPORT #760

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Conversation

Cheshiriks
Copy link
Member

What's done:

  • Fixed bug

This pull request closes #742

@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #760 (dd8ae4f) into master (474f94f) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #760      +/-   ##
============================================
+ Coverage     79.73%   79.79%   +0.05%     
- Complexity     2016     2019       +3     
============================================
  Files            97       97              
  Lines          5074     5078       +4     
  Branches       1621     1621              
============================================
+ Hits           4046     4052       +6     
  Misses          246      246              
+ Partials        782      780       -2     
Flag Coverage Δ Complexity Δ
unittests 79.79% <100.00%> (+0.05%) 0.00 <5.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
.../ruleset/rules/chapter3/files/FileStructureRule.kt 80.51% <100.00%> (+1.85%) 77.00 <5.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 474f94f...dd8ae4f. Read the comment docs.

@Cheshiriks Cheshiriks force-pushed the bugfix/unused-imports branch 2 times, most recently from cf460b6 to b35f3ad Compare February 8, 2021 16:07
  * Fixed bug
  * add test
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cheshiriks Cheshiriks merged commit 2551330 into master Feb 9, 2021
@petertrr petertrr deleted the bugfix/unused-imports branch February 16, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positives in UNUSED_IMPORT
2 participants