Bugfix. New lines rule(#748)

[aktsay6]

Fixed bug mentioned in linked issue

This pull request closes #748

[codecov]

Codecov Report

Merging #749 (39387e4) into master (95434dd) will increase coverage by 0.73%.
The diff coverage is 99.62%.

@@             Coverage Diff              @@
##             master     #749      +/-   ##
============================================
+ Coverage     79.80%   80.53%   +0.73%     
- Complexity     2035     2044       +9     
============================================
  Files            97       97              
  Lines          5106     5298     +192     
  Branches       1633     1638       +5     
============================================
+ Hits           4075     4267     +192     
  Misses          247      247              
  Partials        784      784              

Flag	Coverage Δ	Complexity Δ
unittests	80.53% <99.62%> (+0.73%)	0.00 <71.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
...tlin/org/cqfn/diktat/ruleset/constants/Warnings.kt	97.82% <ø> (ø)	12.00 <0.00> (ø)
...tlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt	81.48% <ø> (ø)	0.00 <0.00> (ø)
...tlin/org/cqfn/diktat/ruleset/utils/KotlinParser.kt	83.01% <ø> (ø)	17.00 <0.00> (ø)
...cqfn/diktat/ruleset/utils/PositionInTextLocator.kt	83.33% <ø> (ø)	0.00 <0.00> (ø)
...qfn/diktat/ruleset/utils/search/VariablesSearch.kt	86.20% <ø> (ø)	19.00 <0.00> (ø)
...eset/utils/search/VariablesWithAssignmentSearch.kt	71.42% <ø> (ø)	6.00 <0.00> (ø)
.../ruleset/utils/search/VariablesWithUsagesSearch.kt	91.66% <ø> (ø)	7.00 <0.00> (ø)
...iktat/ruleset/rules/chapter3/files/NewlinesRule.kt	82.11% <95.83%> (+0.99%)	138.00 <6.00> (+9.00)
...g/cqfn/diktat/ruleset/rules/chapter1/FileNaming.kt	86.95% <100.00%> (+1.95%)	9.00 <1.00> (ø)
.../diktat/ruleset/rules/chapter1/IdentifierNaming.kt	75.00% <100.00%> (+0.33%)	84.00 <1.00> (ø)
... and 64 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95434dd...39387e4. Read the comment docs.

[petertrr]

Suggested change

	// check that it is not listOf(1,2,3...)
	// check that it is not function invocation, but only supertype constructor calls

Suggested change

	// check that it is not listOf(1,2,3...)
	// check that it is not listOf(1,2,3...)

[aktsay6]

Fixed

[petertrr]

It can be merged with handleFirstValueParameter with a couple of additional arguments

[aktsay6]

Merged

[aktsay6]

@petertrr Please, rereview. There was a bug with function calls and it's arguments. Added tests on it. The change is in NewLinesRule file.

[petertrr]

@petertrr Please, rereview.

OK, lgtm